On Fri, May 17, 2019 at 09:31:03AM +0200, Christoph Hellwig wrote: > This method should never be called, so don't waste code on it. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx> > fs/xfs/xfs_icreate_item.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/fs/xfs/xfs_icreate_item.c b/fs/xfs/xfs_icreate_item.c > index 03c174ff1ab3..cbaabc55f0c9 100644 > --- a/fs/xfs/xfs_icreate_item.c > +++ b/fs/xfs/xfs_icreate_item.c > @@ -83,23 +83,12 @@ xfs_icreate_item_committed( > return (xfs_lsn_t)-1; > } > > -/* item can never get into the AIL */ > -STATIC uint > -xfs_icreate_item_push( > - struct xfs_log_item *lip, > - struct list_head *buffer_list) > -{ > - ASSERT(0); > - return XFS_ITEM_SUCCESS; > -} > - > /* > * This is the ops vector shared by all buf log items. > */ > static const struct xfs_item_ops xfs_icreate_item_ops = { > .iop_size = xfs_icreate_item_size, > .iop_format = xfs_icreate_item_format, > - .iop_push = xfs_icreate_item_push, > .iop_unlock = xfs_icreate_item_unlock, > .iop_committed = xfs_icreate_item_committed, > }; > -- > 2.20.1 >