On 5/15/19 1:52 AM, Christoph Hellwig wrote: > On Fri, May 10, 2019 at 04:41:03PM -0500, Eric Sandeen wrote: >> On 5/10/19 3:18 PM, Eric Sandeen wrote: >>> There are a ton of "libxfs_" prefixed functions in libxfs/trans.c which >>> are only called internally by code in libxfs/ - As I understand it, >>> these should probably be just "xfs_" functions, and indeed many >>> of them have counterparts in the kernel libxfs/ code. This is one >>> small step towards better sync-up of some of the misc libxfs/* >>> transaction code with kernel code. >> >> I should have changed internal callers too, will resend after other >> review. > > I have to admit I never got this whole libxfs renaming. Why can't > we just use the xfs_* namespace for libxfs as well to start with? > I'm struggling to understand it as well. I have a 2nd patch to move still more of the shared-ish xfs functions to strip off the "lib" part, and for the rest I don't know - I'm trying to get to where I understand the original intent of all this ... Thanks, -Eric
