On Wed, May 15, 2019 at 04:07:50PM +1000, Dave Chinner wrote: > On Fri, May 10, 2019 at 03:18:25PM -0500, Eric Sandeen wrote: > > Pull functions out of libxfs/*.c into trans_buf.c, if they roughly match > > the kernel's xfs_trans_buf.c file. > > > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > > So I have no problems with this, but I'm not sure what the eventual > goal is? Just sharing code, or is there some functionality that > requires a more complete transaction subsystem in userspace? > > I'm asking because if the goal is eventual unification with the > kernel code, then we probably should name the files the same as the > kernel code so we don't have to rename them again when we do the > unification. That will make history searching a bit easier - less > file names to follow across and git blame works a whole lot better... Even if we don't want to directly share code having the same file name would still be nice..
