On Mon, Feb 04, 2019 at 12:56:28PM -0800, Christoph Hellwig wrote: > > + /* Make sure the old pointer isn't garbage. */ > > + old_value = be32_to_cpu(dip->di_next_unlinked); > > + if (old_value != NULLAGINO && !xfs_verify_agino(mp, agno, old_value)) { > > Couldn't this use xfs_verify_agino_or_null? Oops, missed that. Will fix. --D > Otherwise looks fine: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx>