> + /* Make sure the old pointer isn't garbage. */ > + old_value = be32_to_cpu(dip->di_next_unlinked); > + if (old_value != NULLAGINO && !xfs_verify_agino(mp, agno, old_value)) { Couldn't this use xfs_verify_agino_or_null? Otherwise looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx>