On Sat, Feb 02, 2019 at 08:21:21AM -0800, Christoph Hellwig wrote: > > + struct xfs_agi *agi = XFS_BUF_TO_AGI(agibp); > > + xfs_agino_t old_value; > > + int offset; > > + > > + ASSERT(new_agino == NULLAGINO || > > + xfs_verify_agino(tp->t_mountp, be32_to_cpu(agi->agi_seqno), > > + new_agino)); > > + > > + old_value = be32_to_cpu(agi->agi_unlinked[bucket_index]); > > + trace_xfs_iunlink_update_bucket(tp->t_mountp, > > + be32_to_cpu(agi->agi_seqno), bucket_index, old_value, > > + new_agino); > > As already mentioned by Brian I'd rather pass the agno rather than > recalculating it twice. > > > + agi->agi_unlinked[bucket_index] = cpu_to_be32(new_agino); > > + offset = offsetof(struct xfs_agi, agi_unlinked) + > > + (sizeof(xfs_agino_t) * bucket_index); > > + xfs_trans_log_buf(tp, agibp, offset, > > + (offset + sizeof(xfs_agino_t) - 1)); > > No need for the braces here. Will fix. --D
