On Thu, Jan 31, 2019 at 01:11:09PM -0500, Brian Foster wrote: > The code looks fine, but I don't see any more value in this code than > the similar code down in xfs_iomap_write_allocate(). The comment implies > this skips writeback for the rest of the file, but AFACT the higher > level page->index code in xfs_do_writepage() already does that. All > these checks do is skip the remaining blocks in the current page. When > you consider that we're most likely sending an I/O in the latter case > either way, I'm curious why we'd bother to keep this around at all. It just seems a little pointless to take locks and do a lookup in the extent tree. But I can try dropping it and re-run tests without it.
