On Thu, Jan 31, 2019 at 01:09:58PM -0500, Brian Foster wrote: > > + int flags = XFS_BMAPI_DELALLOC, nimaps = 1, error; > > + > > I'd rather see these on separate lines. Ok. > > flags |= XFS_BMAPI_DELALLOC; > > - return xfs_bmapi_write(tp, ip, bno, 1, flags, total, imap, nimaps); > > + error = xfs_bmapi_write(tp, ip, offset_fsb, 1, flags, > > + XFS_EXTENTADD_SPACE_RES(ip->i_mount, XFS_DATA_FORK), > > Shouldn't this be whichfork? Yeah. Given that this is intended to be folded into your series to clean up the interface for the delalloc helper, do you want to take these bits over?
