On Thu, Jan 17, 2019 at 03:28:08PM -0800, Darrick J. Wong wrote: > > This is just too ugly and pointless. Can you explain (or even better > > show code) why we really need this for xfsprogs? > > To avoid having a useless lock_flags argument to xfs_iget in userspace? > It wasn't so long ago that Eric removed it, but I don't mind adding it > back to avoid this kind of ugliness. I'd rather have prototypes match in userspace then working around mismatches in the kernel. > The mkfs protofile platform_init also has some code to set other > attributes from a struct fsxattr, but I think I can just set them once > the inode allocation function returns to the protofile code. And we are killing that anyway, right?
