On 12/6/18 6:04 AM, Jan Tulak wrote:
> RESEND. It seems that I edited the patch file with an editor that stripped
> the blank spaces that should be stripped by the patch. Sorry. :-D
> Now I verified that the file contains the whitespaces before sending, so
> hopefully it will apply.
>
> Jan
>
> ---
>
> There were many trailing whitespaces through the whole code. As the rate
> of changes in xfsdump is low, it should not cause trouble if we fix it
> in all files at once and avoid issues (unintended changes) with sensibly
> configured editors that automatically remove these on a file save.
>
> Created by this script:
>
> #!/usr/bin/env bash
> # remove trailing whitespaces
>
> find . -name '*.[ch]' ! -type d -exec bash -c '
> sed -i \
> -e "s/\s*$//" \
> $0
> ' {} \;
>
> Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx>
# grep "^-" 1-4-RESEND-xfsdump-style-remove-trailing-whitespaces | grep -v "^---" | grep -v " $" | grep -vP "\t$"
#
looks legit ;)
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Note, please put informational updates like your "RESEND" note /below/
the "---" in a patch, so they don't become part of the commit log
(I'll edit this one out)
i.e.:
[ Normal commit log goes here]
[Signed off by etc goes at the end]
---
[informational info here, diffstat, version updates, etc]
[actual patch follows]
-Eric
