On 11/28/18 6:35 PM, Darrick J. Wong wrote: > On Wed, Nov 28, 2018 at 06:16:37PM -0600, Eric Sandeen wrote: >> On 11/9/18 6:45 PM, Darrick J. Wong wrote: >>> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> >>> >>> We try to load a single inobt record with each FSINUMBERS call. If the >>> chunk is totally empty (which can happen when there are more than one >>> inobt record per block) we should skip to the next INUMBERS call since >>> there are no inodes to bulkstat. >> >> It's not clear to me if this is a bugfix or an optimization, but meh, >> seems like the right thing to do :) > > It's a bug fix for 64k-block filesystems, which can have multiple empty > inobt records that map to a single 64k block; if we try to BULKSTAT an > empty inobt group then we get zero inodes and scrub erroneously says the > fs is broken when in reality it's just stupid. Ok thanks, didn't dig into whether it did needless no-op calls, or something worse. -eric
