Re: [PATCH 7/6] xfs_db: add missing string name for DBM_COWDATA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 11/27/18 5:15 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> In db/check.c, typename[] is supposed to have strings for every DBM_
> type, but we forgot one.  Add it now.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
>  db/check.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/db/check.c b/db/check.c
> index 352aab3f..f5b5e845 100644
> --- a/db/check.c
> +++ b/db/check.c
> @@ -164,6 +164,7 @@ static const char	*typename[] = {
>  	"btrmap",
>  	"btrefcnt",
>  	"rldata",
> +	"cowdata",
>  	NULL
>  };
>  static int		verbose;

Maybe:

/* Every type plus the NULL at the end */
BUILD_BUG_ON(ARRAY_SIZE(typename) != DBM_NDBM + 1);

in init() to avoid this next time?

-Eric



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux