On Sun, Nov 11, 2018 at 12:20:57PM +1100, Dave Chinner wrote: > > > + if (wbc->range_start) > > > + wbc->range_start = round_down(wbc->range_start, bsize); > > > + if (wbc->range_end != LLONG_MAX) > > > + wbc->range_end = round_up(wbc->range_end, bsize); > > > + if (wbc->nr_to_write < wbc->range_end - wbc->range_start) > > > + wbc->nr_to_write = round_up(wbc->nr_to_write, bsize); > > > > This looks fine to me, but I'd be much more comfortable it we had > > it in the common writeback code instead of inside XFS. > > Where in the common code? there's quite a few places that can call > ->writepages... As far as I can tell the only place calling ->writepages is do_writepages, which sounds like the right place to me. Maybe conditional on a block size > page size to reduce the scare factor.
