On Sat, Nov 10, 2018 at 09:47:52AM -0800, Darrick J. Wong wrote:
> > xfs_ilock(ip, iolock);
> > + if (xfs_is_always_cow_inode(ip) && mode != FALLOC_FL_PUNCH_HOLE) {
> > + error = -EOPNOTSUPP;
> > + goto out_unlock;
>
> It's the weekend, so I'm only doing a quick scan of patches:
>
> Why can't we support collapse range, insert range, zero range, or
> unshare in always_cow mode?
Yes, this a little agressive. I think we should be fine just
skipping modes zero and keep size (ugg, the fallocate flags
scheme is horrible..). I'll do that for the next version.
