On Sun, Oct 28, 2018 at 6:13 PM Eric Sandeen <sandeen@xxxxxxxxxxx> wrote: > Check patch 2 as well, the "break;" is also causing corruption I think, > and it should probably just be a no-op ";" Sorry about that. I think it's more than that. The single_fsb function takes care to only write something out when there is something to write and to only recalculate the crc when there has been a change. I'd like to carry over this spirit, but I have the impression that in the end the two functions would become so similar that they will just merge into one. > It may get resolved by the time you get to patch5 but best to not have > regressions along the way. Sorry for the piecemeal review here ;)
