On 10/28/18 7:38 AM, Stefan Ring wrote: > On Sat, Oct 27, 2018 at 1:33 AM Eric Sandeen <sandeen@xxxxxxxxxxx> wrote: >> >> Also, here's an old script I had lying around to test metadump. It's hacky, sorry. >> >> Things to watch out for... it looks for an "fsstress" binary from xfstests, so adjust that path. >> It freezes and unfreezes the test filesystem, if your mount fails it'll freeze >> the fs you're on. ;) There may be other rough spots. >> >> It also runs the xfs_metadump/xfs_db in your path; you could change that to a >> local ./xfs_metadump to run db/xfs_db from a git tree instead for testing >> w/o make install. >> >> Right now this is detecting some corruption induced by metadump/mdrestore >> with your full patchset in place, FWIW. >> >> Sorry I didn't send this sooner, kinda forgot I had it. really should turn it into an xfstest. > > Thanks! The corruption is caused by the last patch in the series. So > dev inodes can have attribute forks. I will have to zap the data and > the attr area separately. Cool, glad it was helpful. Check patch 2 as well, the "break;" is also causing corruption I think, and it should probably just be a no-op ";" It may get resolved by the time you get to patch5 but best to not have regressions along the way. Sorry for the piecemeal review here ;) -Eric
