Re: [PATCH v3 0/2] Try to squash metadump data leaks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/11/18 2:44 PM, Stefan Ring wrote:
> This is the same as v2, but with the correct e-mail address this time. Sorry!
> 
> Stefan Ring (2):
>   xfs_metadump: Extend zapping to multi fsb dir blocks
>   xfs_metadump: Zap more stale data
> 
>  db/metadump.c | 121 +++++++++++++++++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 107 insertions(+), 14 deletions(-)

Still reading through the patches (this stuff makes my brain hurt)

but I think it'd be nice to structure this in a more incremental way, perhaps:

1) fix dir leaf block processing to handle LEAFN
2) add existing leaf block processing to multi-fsb dirs
3) add the dir2 free processing function, and add it to both single & multi-fsb dirs
4) add the process_btinode fixes
5) add the device inode processing

1,2,3 are dependent, 4 and 5 should be independent, they can each be
reviewed for their sole purpose.  One change, one patch.  :)

Thanks,
-Eric



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux