On Wed, Sep 19, 2018 at 05:05:38PM +0200, Jan Tulak wrote: > On Wed, Sep 19, 2018 at 4:49 PM Darrick J. Wong <darrick.wong@xxxxxxxxxx> wrote: > > > > On Wed, Sep 19, 2018 at 02:56:17PM +0200, Jan Tulak wrote: > > > Check if a device is mounted (and issue an error about that) before > > > asking for -f flag. > > > > > > Example of the old behaviour I'm changing: > > > $ mkfs.xfs /dev/sda1 > > > mkfs.xfs: /dev/sda1 appears to contain an existing filesystem (xfs). > > > mkfs.xfs: Use the -f option to force overwrite. > > > > > > $ mkfs.xfs -f /dev/sda1 > > > mkfs.xfs: /dev/sda1 contains a mounted filesystem > > > > I'm confused by the commit message -- what is the new behavior? > > > > Is it this? > > > > $ mkfs.xfs /dev/sda1 > > mkfs.xfs: /dev/sda1 contains a mounted filesystem > > > > $ mkfs.xfs -f /dev/sda1 > > mkfs.xfs: /dev/sda1 contains a mounted filesystem > > Yes. I should put it right into the commit message. With that added, Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D > > Jan > > -- > Jan Tulak > jtulak@xxxxxxxxxx / jan@xxxxxxxx
