On Wed, Jul 25, 2018 at 07:09:51AM -0400, Brian Foster wrote: > Hmm, I originally had this as an inline in the header, so it was in > xfs_trans.h for similar reasons xfs_defer_ops was moved over there (the > function has to access tp->t_dfops). > > I happened to change this over to a non-inline function in v2, but just > left it here for whatever reason. I could probably move it, but I don't > think it's worth it as I already have patches that kill this wrapper off > by updating the only __xfs_defer_cancel() caller (log recovery) to use > an empty container transaction instead of the external dfops. That will > be part of the next set of patches that reduce xfs_defer_ops to a single > list_head and subsequently eliminate the need for the structure... Sounds good, that is even better! -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html