On Thu, Jul 19, 2018 at 09:43:53AM -0700, Christoph Hellwig wrote: > On Wed, Jul 18, 2018 at 08:50:51AM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > The error argument to xfs_btree_del_cursor already understands the > > "nonzero for error" semantics, so remove pointless error testing in the > > callers and pass it directly. > > Looks fine, but we should also get rid of the XFS_BTREE_ERROR and > XFS_BTREE_NOERROR defines as mixing them with errno values is going > to be very confusing. > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > (assuming we get another patch for the above eventually) Eventually, yes. The remaining usages are not so trivial to fix and require more careful auditing. --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
