On Thu, Jul 19, 2018 at 06:32:33PM +0200, Christoph Hellwig wrote: > On Wed, Jul 18, 2018 at 04:40:04PM +0200, Carlos Maiolino wrote: > > > > > > > struct xfs_ifork { > > > int if_bytes; /* bytes in if_u1 */ > > > + unsigned int if_seq; > > > > I wonder if a comment here wouldn't be helpful in the future, like: /* ext list modification counter */ > > Does that really add more value? If so I'm happy having it added > when applying. Seeing as we have anecdotal evidence that more work will be needed if we ever want to use it to track change count in the data fork, I think I'll add the following comment: unsigned int if_seq; /* cow fork mod count */ --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html