On Fri, May 18, 2018 at 03:03:38PM -0700, Darrick J. Wong wrote: > > +/* Check whether we are allowed to dedupe the destination file */ > > +static int allow_file_dedupe(struct file *file) > > Shouldn't this return bool? It's a predicate, after all... Yeah that should be bool. Thanks for pointing it out, I'll fix it up in the next round. --Mark -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html