On Wed, May 02, 2018 at 09:58:56AM -0700, Darrick J. Wong wrote: > > I really see no point in doing the wrapper. I'd much rather keep > > xfs_qm_dqread with a the additional argument, be that a flags value > > or a bool. For example the same patch with the new xfs_dquot_setup > > kept as xfs_qm_dqread and everyone calling it with an additional > > false argument would seem much nicer to me. > > I'm trying to avoid having a can_alloc argument for the exported _dqread > interface because none of the callers outside of xfs_dquot.c set it to > true. That's not really a good reason on its own.. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
