On Wed, May 02, 2018 at 06:34:31PM +0200, Christoph Hellwig wrote: > On Sun, Apr 29, 2018 at 10:44:11PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Move the _qm_dqread functionality to _qm_dqensure, then remove the flags > > argument from xfs_qm_dqread since the only DQALLOC users were internal > > to xfs_dquot.c anyway. > > I really see no point in doing the wrapper. I'd much rather keep > xfs_qm_dqread with a the additional argument, be that a flags value > or a bool. For example the same patch with the new xfs_dquot_setup > kept as xfs_qm_dqread and everyone calling it with an additional > false argument would seem much nicer to me. I'm trying to avoid having a can_alloc argument for the exported _dqread interface because none of the callers outside of xfs_dquot.c set it to true. Later on, in online repair I'll need some kind of interface to allocate and get a dquot with a given transaction, but we can argue about that when we get there. --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
