On 4/20/18 10:22 PM, Xiao Yang wrote: > Hi Eric， > > Before commit 16adcb8 in xfsprogs-dev, only "sunit=0,swidth=0" is vaild > and will convert > into the default stripe config as expected. It behaved the same as the default, because it looked the same as "not set" to all the conditionals in mkfs. > After this commit, both > "sunit=0,swidth=0" > and "sunit=0,swidth=64" will be forced to convert into the default > stripe config. 0,0 should be allowed, to force mkfs to ignore any stripe geometry reported by the device. > If either of sunit and swidth is not 0, should we do a forced conversion? > I am not sure if we should reject the combination(e.g. sunit=0,swidth=64). I am not sure what you mean by "forced conversion" - can you give specific examples? However, a stripe unit of 0 with a non-zero stripe width should probably also be rejected, because it has no meaning. I think it was rejected before, and my commit accidentally allowed it again. It probably needs another test added back in, to check for "both options were specified, but (only) one was zero." Thanks, -Eric > > Thanks, > Xiao Yang -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
