On 4/19/18 3:01 PM, Darrick J. Wong wrote: > I like it better, though on further thought I think I like better the > idea of printing the contents of all potential magic numbers: > > For a block starting with: > > 0xDE 0xAD 0xBE 0xEF 0xCA 0xFE 0xF0 0x0D 0xBA 0xAD... > > xfs_db> p > Unrecognized attr3 block, attempting to print magic numbers and/or blkinfo: > unknown.blockhdr.magic = 0xDEADBEEF > unknown.da_blkinfo.magic = 0xBAAD > unknown.inode.magic = 0xDEAD If we asked for an attr3 type, I don't see the value in printing out structures that are unrelated to an attr3, like an inode....? The whole problem here is that "attr3" is non-specific, and could be several formats. (bad design decision, IMHO, but bridge, water under, etc). So I'd prefer that we only print structures which might be relevant to the thing(s) the user asked for. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
