Re: [PATCH 0/6] xfs: quota fixes and enhancements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Apr 07, 2018 at 05:00:13PM -0500, Eric Sandeen wrote:
> On 4/4/18 1:47 PM, Eric Sandeen wrote:
> > A semi-random smattering of quota stuff.  First three seem quite
> > good to go, the rest are more along the lines of a suggestion
> > or conversation-starter.  ;)
> > 
> > (the first patch is just removing an unused arg).
> > 
> > xfs_repair doesn't look at quota blocks.  At all.  It relies
> > on quotacheck in the kernel to fix them up as needed.
> 
> I'm starting to rethink a lot of this hackery.  Why doesn't xfs_repair
> just fix things up?  (leave quotacheck to the next mount, but the
> "repair" stuff in the kernel seems like a really strange wart.)
> 
> I think I'll look at teaching repair to sanity check the quota
> inodes, but if anyone knows why that's a bad idea please let me
> know.  ;)

/me shrugs, we still need to fix the kernel's quota verifiers to check
the uuid and all that, right?  Which means that both are going to need
patches, afaict.

--D

> Thanks,
> -Eric
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux