On Tue, Mar 13, 2018 at 03:35:56PM +0100, Christoph Hellwig wrote: > Now that we convert COW preallocations from unwritten to real on every > call this function needs to be called with the ilock held exclusively. > > Fortunately we already do that, but update the assert to match. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks ok, Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D > --- > fs/xfs/xfs_reflink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c > index d81c4f868d69..90aac8889dd9 100644 > --- a/fs/xfs/xfs_reflink.c > +++ b/fs/xfs/xfs_reflink.c > @@ -394,7 +394,7 @@ xfs_reflink_allocate_cow( > > retry: > ASSERT(xfs_is_reflink_inode(ip)); > - ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL | XFS_ILOCK_SHARED)); > + ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL)); > > /* > * Even if the extent is not shared we might have a preallocation for > -- > 2.14.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
