On 11/9/17 7:17 PM, Zorro Lang wrote:
> The 'Coverity Scan' found a problem in new write_once() function:
>
> 272 size_t bytes;
> 273 bytes = do_pwrite(file->fd, offset, count, count, pwritev2_flags);
>>>> CID 1420710: Control flow issues (NO_EFFECT)
>>>> This less-than-zero comparison of an unsigned value is never true. "bytes < 0UL".
> 274 if (bytes < 0)
> 275 return -1;
>
> That's unreasonable. do_pwrite return 'ssize_t' type value,
An int, actually, right?
static int
do_pwrite(
...
as does do_pwritev, which it calls:
static int
do_pwritev(
...
Can you chase through the types a bit more for consistency while you're
in here?
Thanks,
-Eric
> which can
> be less than zero, but we use a 'size_t' to get the return value. So
> change the size_t to ssize_t for it can store the return value
> correctly.
>
> Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx>
> ---
> io/pwrite.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/io/pwrite.c b/io/pwrite.c
> index 26f79579..b28b6039 100644
> --- a/io/pwrite.c
> +++ b/io/pwrite.c
> @@ -269,7 +269,7 @@ write_once(
> long long *total,
> int pwritev2_flags)
> {
> - size_t bytes;
> + ssize_t bytes;
> bytes = do_pwrite(file->fd, offset, count, count, pwritev2_flags);
> if (bytes < 0)
> return -1;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
