Re: [PATCH] xfs_io: fix gcc-7 related printf warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/9/17 7:39 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> New compiler, new checks, new warnings.
> 
> Fix the new [-Wformat-truncation=] warnings that io/fsmap.c is
> throwing w/ gcc-7.2 because "%lld..%lld" requires a buffer 40
> characters long, not 32.
> 
> Signed-Off-By: Dave Chinner <dchinner@xxxxxxxxxx>

2^63 is 19 chars, yup.

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

> ---
>  io/fsmap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/io/fsmap.c b/io/fsmap.c
> index 448fb5356466..e46fdbaa148c 100644
> --- a/io/fsmap.c
> +++ b/io/fsmap.c
> @@ -184,8 +184,8 @@ dump_map_verbose(
>  	off64_t			agoff, bperag;
>  	int			foff_w, boff_w, aoff_w, tot_w, agno_w, own_w;
>  	int			nr_w, dev_w;
> -	char			rbuf[32], bbuf[32], abuf[32], obuf[32];
> -	char			nbuf[32], dbuf[32], gbuf[32];
> +	char			rbuf[40], bbuf[40], abuf[40], obuf[40];
> +	char			nbuf[40], dbuf[40], gbuf[40];
>  	char			owner[OWNER_BUF_SZ];
>  	int			sunit, swidth;
>  	int			flg = 0;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux