On Sat, Oct 28, 2017 at 10:08:56AM -0700, Darrick J. Wong wrote: > If the DISCARD of the thin device somehow fails with this message: > > device-mapper: thin: Data device (dm-1) discard unsupported: Disabling discard passdown. > > Then we can end up with arbitrary gunk in the thin device. This causes > mkfs to fail because it's afraid to format the device. Don't be afraid, > just zap it. FWIW mkfs.xfs thinks that the thinp device has an xfs > external log because sometimes the thinp device just happen to be backed > by the log of the previous test's scratch fs. > > Fix this by making the _mkfs_dev helper always format the device, per > Eryu Guan's suggestion. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > common/rc | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/common/rc b/common/rc > index 7e453e0..c441199 100644 > --- a/common/rc > +++ b/common/rc > @@ -642,7 +642,10 @@ _mkfs_dev() > $MKFS_PROG -t $FSTYP -- -F $MKFS_OPTIONS $* \ > 2>$tmp.mkfserr 1>$tmp.mkfsstd > ;; > - > + xfs) > + yes | $MKFS_PROG -t $FSTYP -- -f $MKFS_OPTIONS $* \ > + 2>$tmp.mkfserr 1>$tmp.mkfsstd > + ;; I think the 'yes' pipe can be omitted, I'll fix that on commit. Thanks, Eryu > *) > yes | $MKFS_PROG -t $FSTYP -- $MKFS_OPTIONS $* \ > 2>$tmp.mkfserr 1>$tmp.mkfsstd -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
