On Fri, Oct 27, 2017 at 01:25:50PM -0700, Darrick J. Wong wrote:
> Remove the inode-paths check from _check_xfs_test_fs because we don't
> support inode paths, xfsprogs doesn't have a xfs_{check,repair}_ipaths
> tool, and it's broken anyway because we ignore _check_xfs_filesystem
> (which tells whether or not the filesystem is even still mounted).
>
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
> common/xfs | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/common/xfs b/common/xfs
> index 5643adf..79efb78 100644
> --- a/common/xfs
> +++ b/common/xfs
> @@ -471,13 +471,6 @@ _check_xfs_test_fs()
> TEST_RT="$TEST_RTDEV"
>
> _check_xfs_filesystem $TEST_DEV $TEST_LOG $TEST_RT
> -
> - # check for ipath consistency
> - if $XFS_GROWFS_PROG -n $TEST_DIR | grep -q 'inode-paths=1'; then
> - # errors go to stderr
> - xfs_check_ipaths $TEST_DIR >/dev/null
> - xfs_repair_ipaths -n $TEST_DIR >/dev/null
> - fi
I added a "return $?" here to report _check_xfs_filesystem result to the
caller, otherwise test was reported as a PASS even _check_xfs_filesystem
found something and printed out the error messages.
Thanks,
Eryu
> }
>
> _require_xfs_test_rmapbt()
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
