On Sat, Oct 21, 2017 at 10:13:14AM +0200, Christoph Hellwig wrote: > > > + ASSERT(xfs_isilocked(ip, XFS_IOLOCK_EXCL)); > > > > So it took me a while of wondering "don't we have to have the > > MMAPLOCK_EXCL too?" before realizing that yes, the caller actually does > > grab that too. I wonder if it's worth checking here, since you're > > asserting the lock status at all? > > This just moves the previous code around.. I can send an incremental > patch if you want, though. Sure, either resending this patch or tacking a new one on the end is fine, I don't mind either way. --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
