> > + ASSERT(xfs_isilocked(ip, XFS_IOLOCK_EXCL)); > > So it took me a while of wondering "don't we have to have the > MMAPLOCK_EXCL too?" before realizing that yes, the caller actually does > grab that too. I wonder if it's worth checking here, since you're > asserting the lock status at all? This just moves the previous code around.. I can send an incremental patch if you want, though. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html