On Thu, Sep 07, 2017 at 11:42:53AM +0800, Eryu Guan wrote: > The 'did_zero' param of xfs_zero_range() was not passed to > iomap_zero_range() correctly. This was introduced by commit > 7bb41db3ea16 ("xfs: handle 64-bit length in xfs_iozero"), and found > by code inspection. Looks good. Although this makes me wonder why we pass the argument at all, given that it doesn't seem to matter :) Joking aside: xfs_setattr_size seems to care to write out the buffer cache zeroed byes, so this looks good to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html