On Thu, Sep 07, 2017 at 11:47:09AM -0400, Brian Foster wrote: > The code looks correct because the states ultimately map to the correct > logic, but I think this is actually a misuse of the bmap states. The > contig states are used to define left and right extent contiguity. Here > (and in del_extent_[delay|cow]()) we use them to track extent > replacement alignment, which should be represented by the left and right > filling states (as is done for delalloc/unwritten conversion helpers). > Perhaps we should fix that all up? Sure, will do when reposting. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html