On Thu, Aug 31, 2017 at 12:04:58PM -0400, Brian Foster wrote:
> The ordered variable generates an unused warning on !DEBUG builds.
> Separate the initialization of the associated variables from the
> declarations to quiet gcc.
>
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
> fs/xfs/xfs_buf_item.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_buf_item.c b/fs/xfs/xfs_buf_item.c
> index ef2c137..f5d25f5 100644
> --- a/fs/xfs/xfs_buf_item.c
> +++ b/fs/xfs/xfs_buf_item.c
> @@ -567,10 +567,15 @@ xfs_buf_item_unlock(
> {
> struct xfs_buf_log_item *bip = BUF_ITEM(lip);
> struct xfs_buf *bp = bip->bli_buf;
> - bool aborted = !!(lip->li_flags & XFS_LI_ABORTED);
> - bool hold = !!(bip->bli_flags & XFS_BLI_HOLD);
> - bool dirty = !!(bip->bli_flags & XFS_BLI_DIRTY);
> - bool ordered = !!(bip->bli_flags & XFS_BLI_ORDERED);
> + bool aborted;
> + bool hold;
> + bool dirty;
> + bool ordered;
> +
> + aborted = !!(lip->li_flags & XFS_LI_ABORTED);
> + hold = !!(bip->bli_flags & XFS_BLI_HOLD);
> + dirty = !!(bip->bli_flags & XFS_BLI_DIRTY);
> + ordered = !!(bip->bli_flags & XFS_BLI_ORDERED);
>
> /* Clear the buffer's association with this transaction. */
> bp->b_transp = NULL;
> --
> 2.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
