On Thu, Aug 17, 2017 at 1:22 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > On Thu, Aug 17, 2017 at 11:45:34AM +0200, Jan Tulak wrote: >> On Thu, Aug 17, 2017 at 10:35 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: >> > On Thu, Aug 17, 2017 at 09:38:44AM +0200, Jan Tulak wrote: >> >> The man page is missing description of these options. >> >> Add it. >> > >> > Just remove the options. They are redundant as they cannot be >> > different from the values set by the "-s" sector size options. >> > They aren't documented, so just remove them from mkfs. >> > >> >> The code doesn't look like that. From what it does: >> >> -d sectsize: will set data section sector size >> -l sectsize: will set log section sector size (and as I see now, this >> is not in man page as well) >> -s size: will set both data and log sector size > > If you just look at the option parsing, then it appears that way. > > But go an look at the code that validates and uses these options. > It will only take a log sector size specification for external logs, > other wise it will use the global sector size. Which is the same as > the data section sector size. > > Hence for internal log filesystems, "-l sectsize" is ignored, and > "-s size" and "-d sectsize" set exactly the same variable. And for > external logs, having "-s size" override the "-l sectsize" is > completely wrong, but that's what it does.... > > IOWs, the way the sector size parsing and validation is done is an > utter mess - it's not surprising that nobody can work out what it > does exactly because the code is even more messy and hard to > understand than the CLI interface.... > OK, I agree now that -d sectsize should be removed and -s size should not override log sector size. Cheers, Jan -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
