On Thu, Aug 17, 2017 at 10:35 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > On Thu, Aug 17, 2017 at 09:38:44AM +0200, Jan Tulak wrote: >> The man page is missing description of these options. >> Add it. > > Just remove the options. They are redundant as they cannot be > different from the values set by the "-s" sector size options. > They aren't documented, so just remove them from mkfs. > The code doesn't look like that. From what it does: -d sectsize: will set data section sector size -l sectsize: will set log section sector size (and as I see now, this is not in man page as well) -s size: will set both data and log sector size Does the removal of -d sectsize really make a sense? In any case, the man page needs to be updated to reflect the code. Cheers, Jan -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html