On Tue, Aug 15, 2017 at 1:07 AM, Darrick J. Wong <darrick.wong@xxxxxxxxxx> wrote: > On Fri, Aug 11, 2017 at 02:30:36PM +0200, Jan Tulak wrote: >> Move getnum, check_opt and illegal_option within the file. We have to do >> this to avoid dependency issues with the following patch. There is no >> other change in this patch, just cut&paste of these functions. >> >> Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx> >> --- >> mkfs/xfs_mkfs.c | 236 ++++++++++++++++++++++++++++---------------------------- >> 1 file changed, 118 insertions(+), 118 deletions(-) >> >> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c >> index e3f7d345..3e7ba5f0 100644 >> --- a/mkfs/xfs_mkfs.c >> +++ b/mkfs/xfs_mkfs.c >> @@ -813,6 +813,124 @@ get_conf_raw_safe(const int opt, const int subopt) >> return str; >> } >> >> +static __attribute__((noreturn)) void >> +illegal_option( > > How about declaring the functions at the top and leaving the definitions > where they are? If I remember, Eric thought the opposite. :-) Jan -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
