Hi guys Second version of this set. All issues raised so far should be addressed. The last patch from this set was moved to the other set per Eric's suggestion and see changelog in every patch for specific changes. Plus rebasing changes in every patch. Text from v1 follows: This is a respin of https://www.spinics.net/lists/linux-xfs/msg06158.html, but I decided to split that set in two smaller ones. This first one implements the infrastructure, but does not replace standalone variables with the opts table fields, that happens in the other set. To reiterate: The main goal of this set is to save user input into the opts struct, instead of various ad-hoc variables. I'm adding the set and get functions to do this and applying them where appropriate. Once all the values are in a single place, we can expand the automated validation and use it e.g. for loading up optional config file like Luis wants to do. This set is now is based on for-next and not on my type-chaning set (which will come some time later). Then there are some fixes in specific commits -- all issues you raised should be addressed. You can see the tree for both sets at: https://github.com/jtulak/xfsprogs-dev/tree/setters Cheers, Jan Jan Tulak (6): mkfs: Save raw user input field to the opts struct mkfs: rename defaultval to flagval in opts mkfs: remove intermediate getstr followed by getnum mkfs: merge tables for opts parsing into one table mkfs: move getnum within the file mkfs: extend opt_params with a value field mkfs/xfs_mkfs.c | 1865 ++++++++++++++++++++++++++++++++----------------------- 1 file changed, 1076 insertions(+), 789 deletions(-) -- 2.13.3 -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
