Re: [PATCH RFC 0/2] xfs: refactor ordered buffer logging code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Based on previous discussions, these two look good to me. You can add my review:
Reviewed by: Allison Henderson <allison.henderson@xxxxxxxxxx>

On 08/14/2017 09:54 AM, Brian Foster wrote:
Hi all,

Here's an initial refactoring based on the discussion on Alex's empty
xattr leaf buffer holding patch [1]. These patches split off some of
xfs_trans_log_buf() into a new helper and update xfs_trans_ordered_buf()
to use it and thus eliminate the need to log dirty ranges on ordered
buffers. The secondary purpose here is to create a function that we can
call from deferred ops processing to relog an already dirty/held buffer
across transaction rolls.

Note that this has only been very lightly tested and I might have one or
two more cleanups to tack on. Thoughts, reviews, flames appreciated...

Brian

[1] https://urldefense.proofpoint.com/v2/url?u=http-3A__marc.info_-3Fl-3Dlinux-2Dxfs-26m-3D150227679029089-26w-3D2&d=DwIBAg&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=XFp4B05bcXkJ0dhYaFjd3F8telP01COkBp9cI7mKLb4&m=uWQD8gXmLnvThUaUiXNvMO_K_m7Ggg0h8HanYV0UWOY&s=Tw0p-QrZOdg2EYm3cUzm2ND1Fsoy98wwY9VG8I1viEQ&e=

Brian Foster (2):
   xfs: refactor buffer logging into buffer dirtying helper
   xfs: don't log dirty ranges for ordered buffers

  fs/xfs/libxfs/xfs_btree.c  |  3 +-
  fs/xfs/libxfs/xfs_ialloc.c |  2 --
  fs/xfs/xfs_trans.h         |  4 ++-
  fs/xfs/xfs_trans_buf.c     | 71 ++++++++++++++++++++++++++++------------------
  4 files changed, 48 insertions(+), 32 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux