Hi all, Here's an initial refactoring based on the discussion on Alex's empty xattr leaf buffer holding patch [1]. These patches split off some of xfs_trans_log_buf() into a new helper and update xfs_trans_ordered_buf() to use it and thus eliminate the need to log dirty ranges on ordered buffers. The secondary purpose here is to create a function that we can call from deferred ops processing to relog an already dirty/held buffer across transaction rolls. Note that this has only been very lightly tested and I might have one or two more cleanups to tack on. Thoughts, reviews, flames appreciated... Brian [1] http://marc.info/?l=linux-xfs&m=150227679029089&w=2 Brian Foster (2): xfs: refactor buffer logging into buffer dirtying helper xfs: don't log dirty ranges for ordered buffers fs/xfs/libxfs/xfs_btree.c | 3 +- fs/xfs/libxfs/xfs_ialloc.c | 2 -- fs/xfs/xfs_trans.h | 4 ++- fs/xfs/xfs_trans_buf.c | 71 ++++++++++++++++++++++++++++------------------ 4 files changed, 48 insertions(+), 32 deletions(-) -- 2.9.4 -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html