On 5/12/17 6:05 PM, Darrick J. Wong wrote: > On Fri, May 12, 2017 at 05:29:32PM -0500, Eric Sandeen wrote: >> On 5/8/17 2:47 PM, Darrick J. Wong wrote: >>> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> >>> >>> Introduce a new ioctl that uses the reverse mapping btree to return >>> information about the physical layout of the filesystem. >>> >>> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> >>> --- >>> configure.ac | 1 >>> include/builddefs.in | 7 +++ >>> include/linux.h | 109 +++++++++++++++++++++++++++++++++++++++++++++++++ >> >> So, I'm torn about whether we should be adding all the fsmap definitions >> into xfsprogs. (I know... I did it for statx; I'm wondering if that was a >> bad precedent, and/or if it being a syscall makes it a different situation...). >> >> I don't know when we ever deprecate or remove this stuff. >> >> If you use packaged kernels, you'll get updated headers pretty quickly, right, >> or on a devel box you might install your own? >> >> Not trying to be difficult, just trying to make sure we have a consistent >> plan for new interfaces like this... > > I was under the impression that we employ this evil hackery so that > developers (at least) can build binaries for testing until the kernel > headers in their build environments catch up. Well, like I said, yeah I did it for statx. So, that's probably enough for you to say "stop whining and merge it!" But do we have it for anything else? Ok, we do override fsxattr - that was also your doing. ;) I guess we did the same for the FS_IOC_SET_ENCRYPTION_POLICY stuff, though /that/ is all self-contained in io/encrypt.c. hohum. Ok, let's merge it, but maybe we need a policy of "nuke it after a year" -eric > ...unfortunately, that sort of implies that the sunset horizon is > quite a ways out since I've never seen this stuff get removed. > > --D > >> >> Thanks, >> -Eric >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
