On Wed, Apr 12, 2017 at 10:00:59AM +0200, Christoph Hellwig wrote: > On Tue, Apr 11, 2017 at 11:44:20PM -0700, Darrick J. Wong wrote: > > On Wed, Apr 12, 2017 at 08:00:26AM +0200, Christoph Hellwig wrote: > > > > Looks like _bmapi_remap needs to be able to _iread_extents() if the > > > > data fork hasn't been loaded during log recovery. > > > > > > Yeah, probably. I'll respin once more with that included. > > > > Unfortunately, even after adding in the necessary loading code I still > > get -ENOSPC back from xfs_bmap_add_extent_hole_real which causes log > > recovery to fail. > > The test in your configuration already fails with -ENOSPC for me on > for-next.. Crap, there are actually /two/ problems here: The first problem is that xfs_reflink_end_cow reserves only enough blocks to handle adding 1 extent. This is problematic if we fragment free space, have to do CoW, and then have to perform multiple bmap btree expansions, which g/187 seems to hit. The second problem is that the BUI recovery routine doesn't reserve /any/ blocks to handle btree splits, so when the first problem takes the fs down, recovery also fails. Evidently with 1k blocks we can hit this fairly often in g/187 if the scratch fs is big enough. Ok, patch soon. <sigh> --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
