On Tue, Apr 11, 2017 at 04:02:46PM -0700, Darrick J. Wong wrote: > On Tue, Apr 11, 2017 at 01:10:10PM +0200, Christoph Hellwig wrote: > > The main thing that xfs_bmap_remap_alloc does is fixing the AGFL, similar > > to what we do in the space allocator. But the reflink code doesn't touch > > the allocation btree unlike the normal space allocator, so we couldn't > > care less about the state of the AGFL. > > > > So remove xfs_bmap_remap_alloc and just handle the di_nblocks update in > > the caller. > > Looks ok, will go test. By the way, what release were you targeting > with this patchset? The patches are against for-next. Given how late we are in 4.11 I didn't dare to send them for 4.11, although I'd like to backport it to 4.11-stable and 4.9-stable eventually. > AFAICT the only behavioral change is that we no > longer ensure the AGFL in the remap step prior to (if necessary) > ensuring the AGFL again in the subsequent rmap step. Yes. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html