On 4/6/17 11:03 AM, Darrick J. Wong wrote:
> Apparently FIEMAP for xattrs has been broken since we switched to
> the iomap backend because of an incorrect check for xattr presence.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
nothing tests this? eek. Who wants to fix that? :)
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> fs/xfs/xfs_iomap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
> index 288ee5b..4f118a1 100644
> --- a/fs/xfs/xfs_iomap.c
> +++ b/fs/xfs/xfs_iomap.c
> @@ -1173,7 +1173,7 @@ xfs_xattr_iomap_begin(
> lockmode = xfs_ilock_data_map_shared(ip);
>
> /* if there are no attribute fork or extents, return ENOENT */
> - if (XFS_IFORK_Q(ip) || !ip->i_d.di_anextents) {
> + if (!XFS_IFORK_Q(ip) || !ip->i_d.di_anextents) {
> error = -ENOENT;
> goto out_unlock;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
