On Thu, Mar 16, 2017 at 11:39:11AM -0700, Eric Sandeen wrote:
> On 3/15/17 9:00 AM, Jan Tulak wrote:
> > @@ -640,7 +655,9 @@ struct opt_params {
> > .defaultval = SUBOPT_NEEDS_VAL,
> > },
> > { .index = R_DEV,
> > - .conflicts = { {LAST_CONFLICT} },
> > + .conflicts = { {OPT_M, M_RMAPBT, false, 0, 0,
> > + "rmapbt not supported without CRC support."},
> > + {LAST_CONFLICT} },
> > .defaultval = SUBOPT_NEEDS_VAL,
> > },
> > { .index = R_FILE,
> > @@ -650,7 +667,9 @@ struct opt_params {
> > .conflicts = { {LAST_CONFLICT} },
> > },
> > { .index = R_NAME,
> > - .conflicts = { {LAST_CONFLICT} },
> > + .conflicts = { {OPT_M, M_RMAPBT, false, 0, 0,
> > + "rmapbt not supported without CRC support."},
> > + {LAST_CONFLICT} },
> > .defaultval = SUBOPT_NEEDS_VAL,
> > },
> > { .index = R_NOALIGN,
>
> These two should be:
>
> "rmapbt not supported with realtime devices."
>
> I think.
Yes, rmapbt isn't supported with realtime devices yet.
FWIW we ought to lock out realtime+reflink for the time being too.
At one point I had a prototype for reflink on the rtdev but it bitrotted
and died when the iomap rework came along. I'll get back to it some
day, but first I need to reduce the number of out of tree patches in
djwong-wtf. :)
--D
>
> (sorry for the scattershot review, I'll try to get organized going forward) ;)
>
> -Eric
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
