On 3/15/17 9:00 AM, Jan Tulak wrote: > @@ -640,7 +655,9 @@ struct opt_params { > .defaultval = SUBOPT_NEEDS_VAL, > }, > { .index = R_DEV, > - .conflicts = { {LAST_CONFLICT} }, > + .conflicts = { {OPT_M, M_RMAPBT, false, 0, 0, > + "rmapbt not supported without CRC support."}, > + {LAST_CONFLICT} }, > .defaultval = SUBOPT_NEEDS_VAL, > }, > { .index = R_FILE, > @@ -650,7 +667,9 @@ struct opt_params { > .conflicts = { {LAST_CONFLICT} }, > }, > { .index = R_NAME, > - .conflicts = { {LAST_CONFLICT} }, > + .conflicts = { {OPT_M, M_RMAPBT, false, 0, 0, > + "rmapbt not supported without CRC support."}, > + {LAST_CONFLICT} }, > .defaultval = SUBOPT_NEEDS_VAL, > }, > { .index = R_NOALIGN, These two should be: "rmapbt not supported with realtime devices." I think. (sorry for the scattershot review, I'll try to get organized going forward) ;) -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html