On Fri, Feb 03, 2017 at 12:32:58PM -0800, Darrick J. Wong wrote: > On Fri, Feb 03, 2017 at 05:08:25PM +0800, Hou Tao wrote: > > After successful IO or permanent error, b_first_retry_time also > > needs to be cleared, else the invalid first retry time will be > > used by the next retry check. > > > > Signed-off-by: Hou Tao <houtao1@xxxxxxxxxx> > > --- > > fs/xfs/xfs_buf_item.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/fs/xfs/xfs_buf_item.c b/fs/xfs/xfs_buf_item.c > > index 2975cb2..0306168 100644 > > --- a/fs/xfs/xfs_buf_item.c > > +++ b/fs/xfs/xfs_buf_item.c > > @@ -1162,6 +1162,7 @@ xfs_buf_iodone_callbacks( > > */ > > bp->b_last_error = 0; > > bp->b_retries = 0; > > + bp->b_first_retry_time = 0; > > Looks ok, will try to queue it up as an rc7 fix. It's not a critical bug, nor is it a regression introduced in 4.10-rc1, so IMO it's not a -rc7 candidate fix. Just add it in the for-next queue and mark it for stable. It'll still get to most users at pretty much the same time via the stable trees... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
